p2p-org / solana-swift

MIT License
97 stars 59 forks source link

Check for PublicKey is valid. #72

Closed TheHmmka closed 7 months ago

TheHmmka commented 1 year ago

Just one more property to check if the PublicKey is valid or not.

codecov-commenter commented 1 year ago

Codecov Report

Merging #72 (a31f0af) into main (39917fd) will decrease coverage by 6.28%. The diff coverage is 30.67%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   59.58%   53.30%   -6.28%     
==========================================
  Files         125      142      +17     
  Lines        9534    10835    +1301     
==========================================
+ Hits         5681     5776      +95     
- Misses       3853     5059    +1206     
Flag Coverage Δ
unittests 53.30% <30.67%> (-6.28%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...BlockchainClient/BlockchainClient+Extensions.swift 0.00% <0.00%> (ø)
...olanaSwift/BlockchainClient/BlockchainClient.swift 87.41% <ø> (ø)
...BlockchainClient/Helpers/AskCoin-HD/Keychain.swift 52.28% <0.00%> (-6.92%) :arrow_down:
.../BlockchainClient/Helpers/Borsh/BinaryReader.swift 22.22% <0.00%> (-70.09%) :arrow_down:
...lockchainClient/Helpers/Borsh/BorshSerialize.swift 0.00% <0.00%> (ø)
...wift/BlockchainClient/SolanaBlockchainClient.swift 10.52% <ø> (ø)
...olanaSwift/Extensions/AccountMeta+Extensions.swift 100.00% <ø> (ø)
...rces/SolanaSwift/Extensions/Error+Extensions.swift 0.00% <0.00%> (ø)
...urces/SolanaSwift/Models/AccountInstructions.swift 0.00% <ø> (ø)
...SolanaSwift/Models/BufferLayout/BufferLayout.swift 100.00% <ø> (ø)
... and 45 more

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

TheHmmka commented 1 year ago

Done!