Closed sandreae closed 1 year ago
Patch coverage: 87.79%
and project coverage change: -0.17%
:warning:
Comparison is base (
a404d0c
) 92.50% compared to head (47c902f
) 92.34%. Report is 3 commits behind head on development.:exclamation: Current head 47c902f differs from pull request most recent head b55ebcd. Consider uploading reports for the commit b55ebcd to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
SQLite has BLOB
type for binary data, Postgres has Large Object
or bytea
....
SQLite has
BLOB
type for binary data, Postgres hasLarge Object
orbytea
....
Time to drop support? 😥 Or we use hexadecimal strings for now until we find a better solution anyhow (see my comment below)?
Did you consider not storing blob pieces values at all in the database and retrieve the bytes from the file instead during replication?
https://doc.rust-lang.org/std/io/trait.Seek.html 😎 .. and interesting for writing: https://doc.rust-lang.org/std/io/struct.Cursor.html
I don't think it is too hard but also definitely not required for this development period, I've made a ticket here: https://github.com/p2panda/aquadoggo/issues/553
Did you consider not storing blob pieces values at all in the database and retrieve the bytes from the file instead during replication?
https://doc.rust-lang.org/std/io/trait.Seek.html 😎 .. and interesting for writing: https://doc.rust-lang.org/std/io/struct.Cursor.html
I don't think it is too hard but also definitely not required for this development period, I've made a ticket here: #553
Yeh, this would be ideal. We still store the encoded operation in the db, so we wouldn't actually need to grab the bytes during replication either. Don't know if I want to tackle it right now though but it could be soon :+1: .
MIGRATED TO: https://github.com/p2panda/aquadoggo/pull/554
Bytes
in the database in a new "data" column in theoperation_field_v1
table (not supported by Postgres....)Bytes
we look at this column instead of "value"GraphQL
bytes are represented byHexBytesScalar
📋 Checklist
CHANGELOG.md