p2panda / aquadoggo

Node for the p2panda network handling validation, storage, aggregation and replication
GNU Affero General Public License v3.0
69 stars 5 forks source link

Use `SocketAddr` for all addresses in network config #576

Closed sandreae closed 11 months ago

sandreae commented 11 months ago

Use SocketAddr everywhere in network config rather than MultiAddr.

📋 Checklist

codecov[bot] commented 11 months ago

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (94bc8e9) 92.48% compared to head (f8e62f1) 92.46%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #576 +/- ## ========================================== - Coverage 92.48% 92.46% -0.02% ========================================== Files 106 106 Lines 18396 18400 +4 ========================================== + Hits 17013 17014 +1 - Misses 1383 1386 +3 ``` | [Files](https://app.codecov.io/gh/p2panda/aquadoggo/pull/576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=p2panda) | Coverage Δ | | |---|---|---| | [aquadoggo/src/network/config.rs](https://app.codecov.io/gh/p2panda/aquadoggo/pull/576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=p2panda#diff-YXF1YWRvZ2dvL3NyYy9uZXR3b3JrL2NvbmZpZy5ycw==) | `100.00% <ø> (ø)` | | | [aquadoggo/src/network/service.rs](https://app.codecov.io/gh/p2panda/aquadoggo/pull/576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=p2panda#diff-YXF1YWRvZ2dvL3NyYy9uZXR3b3JrL3NlcnZpY2UucnM=) | `30.42% <0.00%> (+0.38%)` | :arrow_up: | | [aquadoggo/src/network/utils.rs](https://app.codecov.io/gh/p2panda/aquadoggo/pull/576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=p2panda#diff-YXF1YWRvZ2dvL3NyYy9uZXR3b3JrL3V0aWxzLnJz) | `60.86% <0.00%> (-32.47%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/p2panda/aquadoggo/pull/576/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=p2panda)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.