Closed sandreae closed 11 months ago
Attention: 14 lines
in your changes are missing coverage. Please review.
Comparison is base (
94bc8e9
) 92.48% compared to head (acd517d
) 92.66%. Report is 1 commits behind head on main.:exclamation: Current head acd517d differs from pull request most recent head a3ececb. Consider uploading reports for the commit a3ececb to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR fixes a couple of logic errors in the issuing of
blob
tasks which meant already materialized blobs were being written to the filesystem multiple times.blob
tasks when ablob_piece_v1
document being processed in adependency
taskblob_piece_v1
documents in the actualblob
taskAll in all simpler logic :+1:
I think this may also be an issue in
schema
task. The reason being (actually for both cases, cos I copied the logic from there :rofl: ) that we used to not check and issue tasks for reverse relations, so to account for that we had to handle cases when a "child" of a system schema dependency came in and completed the dependency tree. Now that we do issue check for and issue reverse relation tasks we are in effect handling this case twice, which causes extra work.closes: #574
π Checklist
CHANGELOG.md