search

p2panda / aquadoggo

Node for the p2panda network handling validation, storage, aggregation and replication
GNU Affero General Public License v3.0
69 stars 5 forks source link

Inconsitency between aquadogo 0.5.0 and p2padna 0.8.0 #584

Closed Corban-Dallas closed 10 months ago

Corban-Dallas commented 10 months ago

There is an issue with aquadogo's dependency on the p2panda crate using a commit hash instead of an explicit version. If both crates are used in another project, it is impossible to start an aquadogo node from the code due to inconsistencies in the KeyPair structs imported from the p2panda (0.8.0) crate and the ones that aquadogo expects.

Corban-Dallas commented 10 months ago

Well, I think I rushed. It's not unusual thing for packages not being dependent from last version of another package. I should just downgrade p2panda in my project.

sandreae commented 10 months ago

You weren't wrong that it can be bumped though: https://github.com/p2panda/aquadoggo/pull/585 thanks for the reminder.