Closed adzialocha closed 10 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
1a7cefc
) 92.70% compared to head (4fd90dc
) 92.79%.
Files | Patch % | Lines |
---|---|---|
aquadoggo/src/db/stores/query.rs | 92.85% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR fixes the issue we had when pagination suddenly broke for a query over one single sorted field.
We usually order by:
Two things are important in this context:
When multiple fields have been selected by the user and we have duplicate values:
When one field has been selected and we have duplicate values there's an issue:
To fix this we simply just don't order by document id when sorting over one field!
Closes https://github.com/p2panda/aquadoggo/issues/583
📋 Checklist
CHANGELOG.md