Closed jmanm closed 8 months ago
Thanks so much @jmanm for this fix and additional test! Well spotted.
I'm happy to merge this, just one small thing: For whatever reason I can't run our CI against this PR, but I just tested it locally and indeed the format checker is not happy. Can you just run
cargo fmt
and push this again? Otherwise our CI will cry latest when we merge intomain
.Another minor nitpick: The PR number in the
CHANGELOG.md
is wrong (needs to be #603 instead of #602), the link is correct.Thank you!
Done. Thanks for the feedback!
Maybe I'm misunderstanding the logic, but it seems like the condition in
ingest.rs
should be reversed. This addresses #602.📋 Checklist
CHANGELOG.md