p2panda / aquadoggo

Node for the p2panda network handling validation, storage, aggregation and replication
GNU Affero General Public License v3.0
69 stars 5 forks source link

`garbage_collection` task for deleted `blob` when blobs not persisted causes node crash #629

Closed sandreae closed 1 month ago

sandreae commented 2 months ago

When a node does not persist blobs to the filesystem deleting a blob causes an critical error in the garbage_collection task when it attempts to delete a blob file which is assumed to exist.

meli-app | [2024-06-18T21:40:57Z DEBUG aquadoggo::materializer::tasks::garbage_collection] Current view: true
meli-app | [2024-06-18T21:40:57Z DEBUG aquadoggo::materializer::tasks::garbage_collection] Did not delete view: 002032cf68326fd6d1e870998e1ad64c3c64423ee855b7963675563c01ea26376558
meli-app | [2024-06-18T21:40:57Z DEBUG aquadoggo::materializer::tasks::garbage_collection] Purged blob from the database: 002032cf68326fd6d1e870998e1ad64c3c64423ee855b7963675563c01ea26376558
meli-app | [2024-06-18T21:40:57Z ERROR aquadoggo::materializer::worker] Critical error in worker garbage_collection with task <QueueItem 7 w. <TaskInput 002032cf68326fd6d1e870998e1ad64c3c64423ee855b7963675563c01ea26376558/->>: No such file or directory (os error 2)
meli-app | [2024-06-18T21:40:57Z DEBUG aquadoggo::materializer::tasks::garbage_collection] Working on <TaskInput 002057a0c82e45885142ef8a36a9d58a9f637ae82bb5d98dc7f0d875159ddf286c13/->
meli-app | [2024-06-18T21:40:57Z DEBUG aquadoggo::materializer::tasks::garbage_collection] Garbage collect views for document: <DocumentId 286c13>
meli-app | [2024-06-18T21:40:57Z INFO  aquadoggo::manager] Received shutdown signal
meli-app | [2024-06-18T21:40:57Z DEBUG aquadoggo::materializer::tasks::garbage_collection] Handling view with id: 002057a0c82e45885142ef8a36a9d58a9f637ae82bb5d98dc7f0d875159ddf286c13
meli-app | [2024-06-18T21:40:57Z DEBUG aquadoggo::materializer::tasks::garbage_collection] Current view: true