p2panda / aquadoggo

Node for the p2panda network handling validation, storage, aggregation and replication
GNU Affero General Public License v3.0
69 stars 5 forks source link

Unwrap `None` in document store #630

Closed sandreae closed 1 month ago

sandreae commented 2 months ago

So far couldn't reproduce, this occurred on an initial sync with a peer who had plenty of data already (including blobs).

[2024-06-21T17:40:39Z INFO  aquadoggo::graphql::schema] Changed schema bee_species 1c5fe7, rebuilding GraphQL API
[2024-06-21T17:40:39Z INFO  aquadoggo::graphql::schema] Changed schema taxonomy_species 23cb0a, rebuilding GraphQL API
[2024-06-21T17:40:43Z INFO  aquadoggo::replication::manager] Initiate outbound replication session with peer 12D3KooWLrLFv4XsTKkxVW8bo1rDDKnYDuoyzaFwHavbsZJJQGyn (3)
[2024-06-21T17:40:51Z INFO  aquadoggo::materializer::tasks::blob] Creating blob at path /tmp/.tmp3nAFG6/00201a7f587ab84889743a18d9c93a1ae47780dd5ede43451fc6cd3a291491497f88
[2024-06-21T17:40:51Z INFO  aquadoggo::materializer::tasks::blob] Creating blob at path /tmp/.tmp3nAFG6/00204404f40430b5c7fcc27ffc0e11f319c9a8eea06a56fdc2117f5ab2a597925140
[2024-06-21T17:40:52Z INFO  aquadoggo::materializer::tasks::blob] Creating blob at path /tmp/.tmp3nAFG6/00209d6cd079c0c6a032e92055ed1db9138da4f226bbcc64f6cb0cb029a1cce516cb
[2024-06-21T17:40:53Z INFO  aquadoggo::materializer::tasks::blob] Creating blob at path /tmp/.tmp3nAFG6/002043d07824043f21faaa0deff8df9193018153efd9cf9d6caebdc009242c86db59
[2024-06-21T17:40:53Z INFO  aquadoggo::materializer::tasks::blob] Creating blob at path /tmp/.tmp3nAFG6/002071728343c0364720ba2fda750d3fa40acd9700128609f6e34ca8a8d3f6911205
[2024-06-21T17:40:53Z INFO  aquadoggo::materializer::tasks::blob] Creating blob at path /tmp/.tmp3nAFG6/0020c37c23ba842aca578127c0ae660885988fec7a57fe921be90481d062f623e0bd
[2024-06-21T17:40:53Z INFO  aquadoggo::materializer::tasks::blob] Creating blob at path /tmp/.tmp3nAFG6/0020580d789673e60787366798e58656940bec1b6c7e348e1c333e5da13a3853e803
[2024-06-21T17:40:54Z INFO  aquadoggo::materializer::tasks::blob] Creating blob at path /tmp/.tmp3nAFG6/0020ab577da8d0386d8d7d0cf6ec86f2896883d6b53dc94d2e001cfeb8fbb5826070
[2024-06-21T17:40:54Z INFO  aquadoggo::materializer::tasks::blob] Creating blob at path /tmp/.tmp3nAFG6/00205ac7b5f016e0d91d1d3fb7fde014c07ff563dbc3330d18faf5b0e96ab9205b8f
[2024-06-21T17:40:55Z INFO  aquadoggo::materializer::tasks::blob] Creating blob at path /tmp/.tmp3nAFG6/00200d6e2e3ad9f0f4cf99217f14c5bf5286e50538b7f610d50f5e3e87eed75c08ad
[2024-06-21T17:40:55Z INFO  aquadoggo::materializer::tasks::blob] Creating blob at path /tmp/.tmp3nAFG6/00202d7e22575879fa78fdcd0ff9a35dcc882d4ba1f0ec62b86c549281e1d12ec70b
[2024-06-21T17:40:56Z INFO  aquadoggo::materializer::tasks::blob] Creating blob at path /tmp/.tmp3nAFG6/0020d8697905507e20b0f3e4938b78b8217aaab1ab1de1557aac6219162ed0d9296f
[2024-06-21T17:40:57Z INFO  aquadoggo::materializer::tasks::blob] Creating blob at path /tmp/.tmp3nAFG6/00201ff8f7964a1d232db05bfa1e9e912adc69d005805ee21fb4456e6b0d605c2f4a
[2024-06-21T17:40:57Z INFO  aquadoggo::materializer::tasks::blob] Creating blob at path /tmp/.tmp3nAFG6/0020e4375604d4b153dc13d100f0e639fb46128b2c1d102991d744a730de4445a686
[2024-06-21T17:40:58Z INFO  aquadoggo::materializer::tasks::blob] Creating blob at path /tmp/.tmp3nAFG6/002057a6bddd16bfe1759a7af26b4c015cbcd0c12d0014dc2fcc1b049a6548302cfc
[2024-06-21T17:40:58Z INFO  aquadoggo::materializer::tasks::blob] Creating blob at path /tmp/.tmp3nAFG6/0020e92317de2fabe72f2dfa5f431a2a8e83b4b84e54258fa2b5bd2d749023510e81
[2024-06-21T17:40:59Z INFO  aquadoggo::materializer::tasks::blob] Creating blob at path /tmp/.tmp3nAFG6/002062877d14ab289e430905c792e2cb00345cb25f2130564148b6aa250f28f7ffdf
thread 'tokio-runtime-worker' panicked at aquadoggo/src/db/stores/document.rs:174:41:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[2024-06-21T17:40:59Z INFO  aquadoggo::materializer::tasks::blob] Creating blob at path /tmp/.tmp3nAFG6/0020eade7b8ab3e61de0669f8293b9f93b452a292bfe70d6da21e6cd6ef8e8511911
[2024-06-21T17:40:59Z INFO  aquadoggo::materializer::tasks::blob] Creating blob at path /tmp/.tmp3nAFG6/002012676190014a0ce238bd79c03e1a2c365810a9a0a654f962bd10805b59630d8c

https://github.com/p2panda/aquadoggo/blob/35303b16f32be806df2e2385cdf9550946303c2e/aquadoggo/src/db/stores/document.rs#L173-L174

adzialocha commented 2 months ago

It assumes the document wasn't deleted but in a concurrent worker scenario that can be the case?