Issue#73 test send data service

p2pchat / p2pChat

For the UW-Stout Software Engineering Practicum course

MIT License

2 stars 1 forks source link

Issue#73 test send data service #93

Closed Austin-Scott closed 4 years ago

Austin-Scott commented 4 years ago

Closes #73

I don't think this should get merged into master. The marginal increase in testing coverage is not worth the decrease in code readability and maintainability. Also the test is too tightly coupled with the implementation of SendDataService. Long story short: I think this one is dead on arrival. What does everyone else think? Do you think anything in here is salvageable?

Madministrator commented 4 years ago

I'm closing this without merging because the cons of merging outweigh the pros.