search

p2pderivatives / rust-bitcoin-coin-selection

10 stars 5 forks source link

Chore/rust bitcoin preparation #10

Closed Tibo-lg closed 1 year ago

Tibo-lg commented 1 year ago

Fixes #9

yancyribbens commented 1 year ago

Hey @Tibo-lg - thanks for adding this PR. I think there is still some work to make the doc comments legible. For example, if you run the following command from this branch:

cargo doc --open

you'll notice it needs some updates. I guess since you started this PR it makes sense to finish it, otherwise I can add to this PR to fix the doc comments.

yancyribbens commented 1 year ago

Fixed the doc comment compile warning in https://github.com/p2pderivatives/rust-bitcoin-coin-selection/pull/11. Disregard my previous comment.

Tibo-lg commented 1 year ago

@yancyribbens please have a last look I think I fixed everything

yancyribbens commented 1 year ago

@Tibo-lg these changes look good to me.