search

p2pderivatives / rust-bitcoin-coin-selection

10 stars 5 forks source link

Feature/add srd selection #22

Closed yancyribbens closed 1 year ago

yancyribbens commented 1 year ago

I have renamed and moved the random function to it's own module. This feature is similar to SRD in core. Also, I've added effective_value which is used for the sum calculation instead of value. Lastly I did some minor refactoring so that the unit sizes used in the test match core.

murchandamus commented 1 year ago

BTW, I added this repository to my watch list, so if you ask something here, I should also see.

yancyribbens commented 1 year ago

@Tibo-lg I think the only downside to using a Trait instead of a struct is the increased compile time. A monomorphised type has to be constructed at compile time, although the run-time should be the same, so either is probably fine.

yancyribbens commented 1 year ago

I believe this PR is ready to merge. Any objections @Tibo-lg ?

murchandamus commented 1 year ago

Hey, this keeps popping up in my notifications but doesn’t seem to be ready for review. I’ll stop following notifications here for the time being. Please feel free to ping me here again when this PR is ready for review.

yancyribbens commented 1 year ago

Hey, this keeps popping up in my notifications but doesn’t seem to be ready for review. I’ll stop following notifications here for the time being. Please feel free to ping me here again when this PR is ready for review.

Sorry for all the noise. I think it's about ready now, however there seems to be some unrelated failure with the nightly toolchain I'm trying to figure out. Anyway, I think at this point I'll just close this PR and open a fresh one once I figure out what's going on with CI.

yancyribbens commented 1 year ago

@Xekyo a new PR is now open here https://github.com/p2pderivatives/rust-bitcoin-coin-selection/pull/23 - cheers.