search

p2pderivatives / rust-dlc

Rust library for working with Discreet Log Contracts
MIT License
133 stars 37 forks source link

Use `bitcoin::secp256k1` over `secp256k1_zkp` #222

Open bennyhodl opened 1 month ago

bennyhodl commented 1 month ago

As a pre-req to https://github.com/p2pderivatives/rust-dlc/issues/221

I don't see a specific reason for using secp25k1_zkp

Tibo-lg commented 1 month ago

secp256k1_zkp is required to use the ecdsa_adaptor module so I don't think it's possible to use just secp256k1.

bennyhodl commented 1 month ago

I think it would be worth while to convert everything besides the adaptor stuff. Ran into a lot of dependency issues when upgrading ₿itcoin with #223

Tibo-lg commented 1 month ago

I don't think it's possible, the adaptor signature module uses the types from secp256k1 so if they're not from the same version it won't work.

bennyhodl commented 1 month ago

Made a PR #226