search

p2plabsxyz / dscan

A decentralized storage and file-sharing tool that uploads content to IPFS and generates decentralized QR codes.
https://chromewebstore.google.com/detail/dscan-own-your-identity-o/idpfgkgogjjgklefnkjdpghkifbjenap
MIT License
36 stars 26 forks source link

Extension loses focus on file/folder upload #25

Closed anjannair closed 1 year ago

anjannair commented 2 years ago

Describe the Bug

On file/folder upload the extension closes as soon as the focus is shifted to the file picker. This is due to the design of the browser.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Open extension
  2. Click Upload

Expected Behavior

Extension stays in focus and generates QR

Actual Behavior

Extension closes but file picker remains

Additional Details

A good solution to this may be to open a new window to upload file/folder. Something like how the ad blocking extensions work when you open their logs.

akhileshthite commented 2 years ago

Hey @anjannair, Thanks for noticing. I'll keep this issue open. I can assign this to you if you're interested.

anjannair commented 2 years ago

@akhileshthite yes I'll try my best to fix!

anjannair commented 2 years ago

@akhileshthite a fix is ready for the same if you could somehow fast forward with #24 I can open another PR fixing this issue

anjannair commented 2 years ago

The initial pop up when you click the extension image

The final window image

Tested on both FF and Chrome (not tested on Opera, Brave or other Chromium browsers though)

akhileshthite commented 2 years ago

The initial pop up when you click the extension

image

The final window

image

Tested on both FF and Chrome (not tested on Opera, Brave or other Chromium browsers though)

Got it. Will review soon.