p2plabsxyz / dscan

A decentralized storage and file-sharing tool that uploads content to IPFS and generates decentralized QR codes.
https://chromewebstore.google.com/detail/dscan-own-your-identity-o/idpfgkgogjjgklefnkjdpghkifbjenap
MIT License
38 stars 26 forks source link

added Dark-Mode #32

Closed FixxooXD closed 2 years ago

FixxooXD commented 2 years ago

Fixes #28

Closes: #[issue number that will be closed through this PR]

Describe the add-ons or changes you've made

Type of change

How Has This Been Tested?

Checklist:

Screenshots (Only for Front End and UI/UX Designers)

Original Updated (Before)

Screenshot (102) ----------: |:--------------------: Original Screenshot | Updated Screenshot | (After) Screenshot (104)

Dark-Mode Screenshot (105)

akhileshthite commented 2 years ago

Fixes #28

Closes: #[issue number that will be closed through this PR]

Describe the add-ons or changes you've made

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Code style update (formatting, local variables)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Checklist:

  • [x] My code follows the "contribution guidelines" of this project.
  • [x] I have performed a self-review of my own code.
  • [x] I have commented my code, particularly wherever it was hard to understand.
  • [x] My changes generate no new warnings.
  • [ ] Any dependent changes have been merged and published in downstream modules.

Screenshots (Only for Front End and UI/UX Designers)

Original | Updated (Before) :---------- Screenshot (102) ----------: |:--------------------: Original Screenshot | Updated Screenshot | (After) Screenshot (104)

Dark-Mode Screenshot (105)

Hey @FixxooXD, Sorry to say this PR is not valid for production and hence cannot be merged.

You did not follow any rules given in the contribution guide.

Specifically:

Hope you take these as a learning :)

FixxooXD commented 2 years ago

hey @akhileshthite thanks for the review Iam, new to this things it will really help me in future and sorry for the poor PR . Can you suggest me what kind of library I should have used instead of CDN .

akhileshthite commented 2 years ago

hey @akhileshthite thanks for the review Iam, new to this things it will really help me in future and sorry for the poor PR . Can you suggest me what kind of library I should have used instead of CDN .

No worries :) All the best!

As you used bootstrap CDN for styling in HTML file, you should have used bootstrap library instead.