Split qrcode script in several files for maintainability - Githubissues

p2plabsxyz / dscan

A decentralized storage and file-sharing tool that uploads content to IPFS and generates decentralized QR codes.

https://chromewebstore.google.com/detail/dscan-own-your-identity-o/idpfgkgogjjgklefnkjdpghkifbjenap

MIT License

36 stars 26 forks source link

Split qrcode script in several files for maintainability #44

Closed btwsuraj closed 10 months ago

btwsuraj commented 10 months ago

Related Issue (if any)

Closes: #44

Describe the add-ons or changes you've made

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Checklist:

[x] My code follows the "contribution guidelines" of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[x] My changes generate no new warnings.
[x] Any dependent changes have been merged and published in downstream modules.

Screenshots (Only for Front End and UI/UX Designers)

Original	Updated
Original Screenshot	Updated Screenshot

akhileshthite commented 10 months ago

Hi @btwsuraj! Thank you for your interest.

Someone already made a PR on this and discussed it in the issue #40 before you did.