p2plabsxyz / dscan

A decentralized storage and file-sharing tool that uploads content to IPFS and generates decentralized QR codes.
https://chromewebstore.google.com/detail/dscan-own-your-identity-o/idpfgkgogjjgklefnkjdpghkifbjenap
MIT License
35 stars 26 forks source link

bug: size of qrcode is not fixed when data string is different #48

Closed akhileshthite closed 6 months ago

akhileshthite commented 10 months ago

_Originally posted by @akhileshthite in https://github.com/p2plabsxyz/dscan/pull/46#discussion_r1367903980_

QR code display issue with long name files:

file_qr_code_display_issue

QR code display issue with folder:

folder_qr_code_display_issue

I tried changing the values here and found that 140 works perfect, but it will mess the file's QR code.

export var QR_CODE_DISPLAY = createQRCodeFor(140);

Expected behavior:

The generated QR code should fit in a fixed size 150 regardless of its link length just like previously.

Learningcomputers777 commented 10 months ago

Can you elaborate more on this issue and provide the files where it is.

akhileshthite commented 10 months ago

Can you elaborate more on this issue and provide the files where it is.

Hey @Learningcomputers777,

Please read this thread https://github.com/p2plabsxyz/dscan/pull/46#discussion_r1367903980_ to learn more about the issue.

Files: ./src/scripts/web3Storage.js ./src/scripts/qrHandler.js ./src/scripts/utils.js