Closed AnishDe12020 closed 2 years ago
qrcode.js
file with prettier?"Add"
instead of "Added"
.Issue 1:
Increase the size of this download SVG, it should match the size of other SVGs.
Issue 2: The footer is not visible, move the download SVG up.
Issue 3:
Make the Download SVG centered as per the generated QR code.
@AnishDe12020, Resolve those issues, then I'll review it again.
@AnishDe12020, Resolve the those issues, then I'll review it again.
Yep, I have resolved them, can you review it?
@AnishDe12020, Resolve the those issues, then I'll review it again.
Yep, I have resolved them, can you review it?
Can you please check all of my review comments carefully? Go through it. I expect reply for each review comment with FIX commit link.
- Did you format
qrcode.js
file with prettier?- Please use imperative tense to write commit messages,
"Add"
instead of"Added"
.
Ya, I had used prettier, it formats on save actually. I am not sure if I can change the commit message now
Issue 3: Make the Download SVG centered as per the generated QR code.
Fixed in https://github.com/AkhileshThite/dscan/pull/9/commits/da00d8b8b00d49f0bec6bd7e7c64d1beb72bf66f
Issue 1: Increase the size of this download SVG, it should match the size of other SVGs.
Fixed in https://github.com/AkhileshThite/dscan/pull/9/commits/da00d8b8b00d49f0bec6bd7e7c64d1beb72bf66f
Issue 2: The footer is not visible, move the download SVG up.
Fixed in https://github.com/AkhileshThite/dscan/pull/9/commits/5d6d5f4cd04c567894988ff9d5e61c883af93bae
- Did you format
qrcode.js
file with prettier?- Please use imperative tense to write commit messages,
"Add"
instead of"Added"
.Ya, I had used prettier, it formats on save actually. I am not sure if I can change the commit message now
No need to change now, but keep that in mind.
Change in CSS header:
margin-bottom: 40px;
@AnishDe12020 Make these 3 changes.
@AnishDe12020 Make these 3 changes. I have made them in https://github.com/AkhileshThite/dscan/pull/9/commits/d295fffd833e39076465d03476c4fa34603d7bd6. Do let me know if it is fine
@AnishDe12020 Make these 3 changes. I have made them in d295fff. Do let me know if it is fine
Good work.
Related Issue
Closes: #2
Describe the add-ons or changes you've made
I have added a download button (SVG from heroicons) which when clicked, download the qrcode as an image. To make things simples, I have added a line of code in the
qrcode.js
file which ass an id ofqr-code-image
to the image element housing the qr code. On clicking download, the base64 src is obtained from the image, and the download code is executed.Type of change
What sort of change have you made:
How Has This Been Tested?
I have uploaded an image (as a file), got the qrcode generated and clicked the download button which triggered a download and I have opened the generated png and it matched the shown png. I have also scanned it with my phone and it worked as intended.
Checklist:
Screenshots (Only for Front End and UI/UX Designers)