search

p2pool / p2pool

Peer-to-peer Bitcoin mining pool
http://p2pool.in/
GNU General Public License v3.0
1.15k stars 1.02k forks source link

Allow --outgoing-conns to be more than 10 #68

Open MobiusL opened 11 years ago

MobiusL commented 11 years ago

Increase the limit of --outgoing-conns to 40 People can then fine tune for their own setup.

Rav3nPL commented 11 years ago

I`m not sure it is good idea. Not all nodes have open ports to get incoming traffic. This can lead to create closed clusters of nodes.

yhaenggi commented 11 years ago

not really, there are more than 150 (max value i tested) p2pool instances with an open port! the more connections the bigger the "nesting", therefore "bigger" p2p. if you would set it to 1 then clusters could be created, otherwise not.

Delta1977 commented 11 years ago

my opinion: if i have one static ip and the port in my router is forwarded i have in exaple 6 outgoing and 40 incoming Connections. thats 46 nodes I' am connected normaly. If the port is not forwarded my max connections are limited to 10 outgoing and 0 incomming.!!

In the other example :With dynamic ip i dont have a chance to get enought incoming Connections althougt zhe port is open!!

Lets set an standartvalue for outgong connections and let's the people finetune for their own.

The other option would be to worklike some parts of bitcoind. 1) Define a maximum number of connections (inbound and outbound) and reducing the outgoing connections if incoming connects. 2) establish the parameters externalip =. This should also support DNS. As a result, instead of my dynamic IP, my dNSName (like dyndns) is communicated to the other nodes. And this points to my current IP.

Sorry for my bad english

Greets

Rav3nPL commented 11 years ago

Something like "node hash" and actual IP number and port and "last seen" sent via nodes, like in torrent/kad/overnet p2p.

wtogami commented 11 years ago

This is a bad idea for another reason: p2pool is not threaded. It handles all connections sequentially. The delay between receiving a new share and giving new work to workers increases with each connection. There is thus a tradeoff between having more direct connections with peers and adding more delay to your workers.