Uploaded images don't always have the correct file permissions

p2pu / learning-circles

Create local study groups and learn together.

https://learningcircles.p2pu.org

MIT License

13 stars 9 forks source link

Uploaded images don't always have the correct file permissions #680

Closed dirkcuys closed 4 years ago

dirkcuys commented 4 years ago

Some uploaded images are mode 600 instead of 644. It may be big images?

GrifP commented 4 years ago

This is meant to addressed the stretched images that appear on Wichita's page, right?

https://www.p2pu.org/wichita/

dirkcuys commented 4 years ago

@GrifP nope, this isn't about stretched images. That would be a styling issue. Please create a separate issue for that on https://github.com/p2pu/p2pu-website

dirkcuys commented 4 years ago

The problem is caused by how bigger file uploads are handled. Smaller files are buffered in memory and written to file while bigger uploads are streamed to a temporary file that is moved afterwards. See django docs and a related issue in another project.