search

p2r3 / epochtal

Portal 2 tournament system
GNU General Public License v3.0
6 stars 4 forks source link

Buggy animation on website after some time #22

Open PancakeTAS opened 2 months ago

PancakeTAS commented 2 months ago

Not entirely sure how to replicate this 100%, I believe just having epochtal opened in a tab that is not highlighted seems to cause this.

Since multiple people have reported this behavior, I've created this issue here.

https://github.com/user-attachments/assets/02c5faed-c695-4096-8dc7-89c1b28552ed

p2r3 commented 2 months ago

This is incredibly odd, and is probably an issue in something much lower level than we can realistically approach from client JS. My reasoning for this is that it seems to depend on not just the browser, but also the GPU. I have never experienced this issue on my AMD cards, namely the RX 570 or R7 240, but have started running into similar graphical glitches on a Nvidia GT 1030. In each of these cases only the GPU was swapped, the rest of the system and the OS/browser used remained the same.

There's probably some undefined behavior being encountered. The whole bg.js script deserves a refactor - the main logic of the canvas animation is admittedly the work of ChatGPT, with only slight tweaks from me.

p2r3 commented 1 month ago

@PancakeTAS *bump*

Has this been fixed by #46? I generally keep the background animation turned off on my system so I'm not likely to notice.

PancakeTAS commented 1 month ago

I haven't been able to replicate it yet, I will close the issue until the issue appears again

PancakeTAS commented 1 month ago

It doesn't flicker, but the animation now lags back and forth.. sort of like the sound when valve games crash

soni801 commented 1 month ago

This is really nitpicky, but if you can't reproduce it but still knows it happens, you should close the issue as wontfix instead of completed

PancakeTAS commented 1 month ago

I marked it as completed as we merged another pull request that seemed to have fixed it, so naturally it's a completed issue. 'Won't fix' is not even meant to be used in this context. It's meant to be used for issues that the maintainer has decided against fixing, or are fully out of control and unfixable. Also on a sidenote, we should discuss these things on the discord instead of the issue