p2r3 / epochtal

Portal 2 tournament system
GNU General Public License v3.0
6 stars 4 forks source link

Consider removed runs when assigning points #24

Open p2r3 opened 1 month ago

p2r3 commented 1 month ago

One of the issues brought up when discussing the new points system was that runners could remove their runs from the leaderboard if they knew they'd lose points with their current placement. To prevent this, points should be calculated from the player's most recent logged submission (in week.log) regardless of if they've removed it. However, admins should still be able to remove invalid runs from the log completely.

Resolving this issue consists of performing three tasks:

  1. Modifying the points util to consider all submissions, ignoring removal markers;
  2. Creating a weeklog command which cuts out a submission from the buffer entirely, without leaving a removal marker;
  3. Modifying the leaderboard run removal command to allow for optionally purging the log entry.
p2r3 commented 1 month ago

Important side note - when recalculating points from archives, removal markers should still be considered for pre-repochtal weeks (<133), as only admins could remove runs during this time.