search

p2r3 / epochtal

Portal 2 tournament framework
https://epochtal.p2r3.com/
GNU General Public License v3.0
8 stars 4 forks source link

Remove unused variables #55

Closed soni801 closed 4 months ago

soni801 commented 4 months ago

The epochtal code does have quite a few unused variables. I'm too scared to remove them myself, but looked through all I could find and marked them with a comment. I'd appreciate if someone else could double check that these are actually unused, and then remove them before merging this. I'll leave it open as a draft now.

PancakeTAS commented 4 months ago

Can you just.. delete them? Marking them with FIXME is so completely pointless

soni801 commented 4 months ago

I'd like for someone with a better understanding of the codebase than me to double check that they can actually be safely removed before i do it. i could do it myself, but it's easier (and probably safer) if someone else does that :D

If nothing has happened after i've implemented docker support, i'll go back to this and remove everything and undraft this pr