search

p2r3 / epochtal

Portal 2 tournament framework
https://epochtal.p2r3.com/
GNU General Public License v3.0
8 stars 4 forks source link

fix: scroll-anims #61

Open ArcherTheReal opened 2 months ago

ArcherTheReal commented 2 months ago

I fixed the visual bugs mentioned by rudko and also added a toggle at the bottom

PancakeTAS commented 2 months ago

I am against the idea of adding an extra toggle for this.. If one even has a reason to want to turn them off, then the effect is already too aggressive. Instead, this should tie into power saving probably

ArcherTheReal commented 2 months ago

@p2r3 said to add a toggle for it, but i can easily merge it with the other one if needed

p2r3 commented 2 months ago

There's no reason not to give people this customization option, especially not if it's out of principle. It doesn't cost us anything to add an extra toggle.

soni801 commented 2 months ago

I agree with pancake here. There shouldn't be any reason for people to want to disable this, other than potentially power savings. The only thing we're gonna achieve by adding a toggle is making the site more cluttered.

p2r3 commented 2 months ago

The clutter in question is a thin toggle at the bottom of the page, but I yield. If it's 2 to 1, then do just rename the existing toggle and bundle this with it.

ArcherTheReal commented 2 months ago

We can also make a dropdown at the bottom, so its a text called settings and clicking it makes all settings pop out and back in, in case we add more later, although this isn't necessary for the time being

PancakeTAS commented 2 months ago

stale?

ArcherTheReal commented 2 months ago

Cant work on this atm