search

p2r3 / epochtal

Portal 2 tournament framework
https://epochtal.p2r3.com/
GNU General Public License v3.0
8 stars 4 forks source link

Progressbar for curation #71

Closed ArcherTheReal closed 2 months ago

ArcherTheReal commented 2 months ago

I feel it would be cool for a progressbar to exist while the curation algorithm is working, because it takes so long

p2r3 commented 2 months ago

Is this... necessary? I'm really not so sure. @PancakeTAS @soni801 thoughts?

ArcherTheReal commented 2 months ago

Now that i think about it, i realized that the thing is shown in your terminal and not on the cli as its automated and not run by organizers

ArcherTheReal commented 2 months ago

Ill close this as not planned

rudkoLA commented 2 months ago

does it even matter how long it takes if it's done after the leaderboard locks instead of when the map releases

ArcherTheReal commented 2 months ago

No i was just thinking about it as being run from the cli cause thats where i was running it from

PancakeTAS commented 2 months ago

Hmmmm... My local epochtal is still curating and it has been for the past 25 minutes. Before, curation took maybe 10 sometimes 15 minutes which means this week has a bunch more maps uploaded compared to last week. Now as far as I know, epochtal does not know how many maps there are on the workshop until it fetches the last batch of maps at which point it's already done curating. That would make a progress bar hard to implement.

Alright, how about status updates then? Print to the console how many maps have been curated thus far to see if the algorithm is actually doing something or stuck in an infite loop. I don't see a use for this whatsoever, there aren't even any loops that could potentially be infinite in the source code for the curation.

Now, seeing how the progress bar would likely be in the CLI and no one even has the CLI opened, I don't think this is worth implementing. There's other ways to check if the curation algorithm is doing something or not (e.g. look at task manager/htop/btop).

Don't close the issue to prematurely by the way, at least wait like 10 minutes :sob: