search

p2r3 / epochtal

Portal 2 tournament framework
https://epochtal.p2r3.com/
GNU General Public License v3.0
8 stars 4 forks source link

Trying to playback video proof while logged out results in 404 #96

Open soni801 opened 1 month ago

soni801 commented 1 month ago

The fact that the video doesn't play isn't really an issue, but we should probably provide a more descriptive error message than 404. Well, 404 is kinda wrong anyway.

Steps to reproduce:

  1. Log out from epochtal.p2r3.com
  2. Find a run with video proof (I used week 9 to test)
  3. Click the video button

It should be noted that the error given when you try to download a demo while logged out is also presented in a bad way, but at least it tells you what the problem is (ERR_LOGIN).

p2r3 commented 1 month ago

I think this happens because the first request for the link correctly returns "ERR_LOGIN", which is then for whatever reason not checked and thrown into the link's href attribute. In my opinion the solution here should be to just not require login at all for fetching archive proof.