p2sr / SourceAutoRecord

Speedrun plugin for Source engine games.
MIT License
89 stars 27 forks source link

Segmentation fault in `SND_RecordBuffer_Hook` #180

Closed p2srluma[bot] closed 8 months ago

p2srluma[bot] commented 1 year ago

https://discord.com/channels/146404426746167296/811780246608281650/1115615767132643418


This action was performed automatically, triggered by a report by discord user nekzor#0 at 06-06-2023 12:18:46 UTC.

NeKzor commented 1 year ago

Adding more context:

0xcaef364c in SND_RecordBuffer_Hook () at src/Features/Renderer.cpp:992
992     for (int i = 0; i < *g_snd_linear_count; i += g_render.channels) {

These offsets here might be outdated: https://github.com/p2sr/SourceAutoRecord/blob/e289b9072066db2df5a0ee75522f8c7774914d8b/src/Features/Renderer.cpp#L1161-L1169

mlugg commented 1 year ago

Not unlikely, I remember these offsets being very finicky and weird. Unfortunately I don't think there's a more reliable way to get at these pointers so we'll just have to correct the offsets

ThisAMJ commented 8 months ago

Fixed by cbdc05662b10e5f81851da66c9cdeabe5a3728a2