search

p2w34 / wlips

Word Lists Improvement Proposals (extending BIP-0039)
MIT License
12 stars 9 forks source link

guidelines for hebrew #58

Open eyaler opened 3 years ago

eyaler commented 3 years ago

Following the request for help in guidelines for other languages, and after working on the now deferred Hebrew wordlist, I would like to suggest these high-level guidelines derived from our recent work, which I believe are useful for future Hebrew word lists.

p2w34 commented 3 years ago

@eyaler thank you. This PR will be left unmerged and once this repo gets enough traction to think about other languages, it should be revisited. Let me mention again the need for the preliminary word list -> creation a couple of word lists based on it (also to prove the approach is right) -> focus on other languages.

eyaler commented 3 years ago

i would suggest then to remove to call for help in other languages... also i believe that Hebrew may have its unique challanges and opportunities which may benefit from not limiting ourselves to the english wordlist

p2w34 commented 3 years ago

I hoped that section: https://github.com/p2w34/wlips/blob/master/contributors-faq.mediawiki was clear but to avoid future confusion I removed 'help needed' where it does not apply for now.

Let me also clarify, for future readers - the PR with the Hebrew list was indeed rejected. The way it was created does not comply with the vision/roadmap of this repo. I checked and it was moved 1:1 from the main bitcoin repo - there was never any promise the existing PRs from the main bitcoin repo would be simply moved here. This repo has its own vision, with the aim of approaching the creation of all the word lists together.

eyaler commented 3 years ago

I have worked on the list after its rejection just to fix syntax and duplication errors (PR is now accepted). there were other issues most prominently regarding word similarity and we have work in progress to create a better list based on hebrew corpora, optimizing for usability and robustness and considering somewhat generalized security principles. but we have put this on hold following the PR rejection. anyway, without going into the discussion of the applicability and efficiency of the general wordlist to other languages, the suggested guidelines are on the linguistic level, and would be relevant both for a translated list and a new list.