search

p3lim-wow / BonusRollPreview

Easily see what the bonus loot roll can yield
Other
9 stars 2 forks source link

Error report v46 #34

Closed Cluuey closed 5 years ago

Cluuey commented 5 years ago

This error popped up in Battle for Dazar'alor, I haven't had a chance to go back but I disabled the addon as I couldn't see loot in the dungeon journal either.


[C]: in function `EJ_SelectInstance'
BonusRollPreview\BonusRollPreview-80000.46-Release.lua:128: in function `StartEncounter'
BonusRollPreview\BonusRollPreview-80000.46-Release.lua:98: in function <BonusRollPreview\BonusRollPreview.lua:54>

Locals:
InCombatSkipped```
Cluuey commented 5 years ago

I just noticed the following error in BugSack was the dungeon journal and thought that might help you. I don't know if it will but more information is normally better than too little.

[C]: in function `EJ_SelectInstance'
...zzard_EncounterJournal\Blizzard_EncounterJournal-1.0.lua:631: in function `EncounterJournal_DisplayInstance'
...zzard_EncounterJournal\Blizzard_EncounterJournal-1.0.lua:2286: in function `EncounterJournal_OpenJournal'
FrameXML\LootFrame.lua:852: in function <FrameXML\LootFrame.lua:834>

Locals:
(*temporary) = 0
gixxpunk commented 5 years ago

That's because the addon is missing the InstanceID of Battle of Dazar'alor raid in this file: https://github.com/p3lim-wow/BonusRollPreview/blob/master/libs/EJ_Ext/EJ_Ext.lua

Something like: [XXXX] = 14, -- Raid: Battle of Dazar'alor

p3lim commented 5 years ago

Please try the latest version from GitHub, I don't raid any more so I can't test until LFR becomes available.

Cluuey commented 5 years ago

Will do. I guess that will be some time tomorrow but I'm in Oz so much later than US players.

p3lim commented 5 years ago

@Cluuey Had a chance to test yet?

Cluuey commented 5 years ago

Sorry I haven't got back to you, I've been unwell.

I had meant to ask how to use the version from here as just downloading the zip file, extracting it and changing the folder name, didn't work. It gave errors about missing the Wasabi library.

So I replaced the file gixxpunk mentioned above, but that didn't work either.

Then I got sick and hadn't looked into it further. Looking now I'll grab the missing libs directories from the previous version and see if it works.

p3lim commented 5 years ago

For this change, you only need to replace BonusRollPreview.lua with the one from GitHub.

Cluuey commented 5 years ago

I didn't get any errors the other night, so I'd say you've sorted this out. Thanks. :-)

p3lim commented 5 years ago

👍

p3lim commented 5 years ago

https://github.com/p3lim-wow/BonusRollPreview/commit/03b5ad144dec2e74b9c96559757b82025831b3a1