p3lim-wow / ExtraQuestButton

An extra button for quest items!
Other
14 stars 1 forks source link

More special cases #49

Closed Nulgar closed 1 year ago

Nulgar commented 2 years ago

During the WQ Drawing Out the Poison you loot the Phylactery of Arin'gore, which you need to use to summon the target mob. Simple questItems addition.

The Korthia/Archivists' Codex quest Diviner's Rune Chits has you randomly loot Diviner's Rune Chits from treasures in Korthia, which have to be used to gain actual quest progress, and thus aren't displayed in the quest tracker for EQB to pick up on automatically. (Similar to BfA's The Great Sea Scrolls / Tortollan Pilgrimage Scrolls, in fact) I added this to the questItems section in my local copy, and also had to add it to inaccurateQuestAreas, since the quest itself has no defined quest area. I suggest the areas { 1961, 2006, 2007 } for Korthia and its two caves with their own map, although given the nature of the quest, a simple true would also fit, you'd want to use the items as soon as possible anyway, and you only loot them in Korthia... but let's not get too philosophical, I'll leave the decision to your opinion.

I noticed you added the items for Who Devours the Devourers?, but Lua ignores the first entry for the green item (other languages would complain about using an array index/key twice) You'd have to use a table to store both itemIDs under the same questID index, and then account for that in the determining function, use the first item from the table that you possess (priority on the blue item, in this case)

PS: While this ticket is still open, a thing I found while levelling: Boom Boots (for both H/A versions of A Breath of Fresh Air) need an entry in completeItems, as the quest is 'complete' on accept. UiMapID is 205, Shimmering Expanse (although the code currently just looks for a non-false value in the array)

p3lim commented 2 years ago

I'll take a look at this once I have an active subscription again, which will probably be 9.2.

p3lim commented 1 year ago

https://github.com/p3lim-wow/ExtraQuestButton/commit/148d9a2b4062110ab03cd933c1c9631cfb748289 https://github.com/p3lim-wow/ExtraQuestButton/commit/a94f377bb5842f0d1e42e87dd8edef55323ff1dc https://github.com/p3lim-wow/ExtraQuestButton/commit/28080aa80f6f3ffd9b49ce8b80ea4c4d4c7f89a4