search

p3lim-wow / ExtraQuestButton

An extra button for quest items!
Other
14 stars 1 forks source link

Possible Memory Leak #50

Closed linaori closed 2 years ago

linaori commented 2 years ago

Describe the bug EQB memory usage grows at a linear rate. It starts at <1mb and gradually goes up. Earlier I had it on 10MB+.

How to reproduce Just having it enabled seems to cause it

What did you expect? A more consistent memory usage

Error report n/a

Screenshots https://user-images.githubusercontent.com/1754678/143659892-6e106a11-a75c-4e56-9937-f95d685adc5a.mp4

linaori commented 2 years ago

After doing some digging, I've traced the memory increase to this line, and I can't seem to figure out what's causing it. There doesn't seem to be anything wrong in this code from what I can tell, will do more digging later.

https://github.com/p3lim-wow/ExtraQuestButton/blob/28cbf2b5687173476e45c89ab7b61c22103b01a8/Utils.lua#L159

p3lim commented 2 years ago

It's an API that is being basically polled, not just by this addon, but by the default interface and multiple other addons.

There is no good way of dealing with this, and while I could add some form of caching around the quest log it wouldn't be of any great benefit.

It's up to Blizzard to either change how the API works, how often it needs to be called to get this type of information, or just improve it as-is.