search

p3lim-wow / InteractiveWormholes

Shows clickable locations on the World Map when using engineering wormholes
Other
4 stars 5 forks source link

New module - Skyhold flight NPC #11

Closed tiker closed 5 years ago

tiker commented 5 years ago

This is for the flight master (Stormflight Master) NPC in Skyhold (class hall for Warriors in Legion).

There's probably a better icon to use than the flight master boot but I don't know what to use for this at the moment.

"Broken Shore" is one of the destinations but it is already translated so I left it where it is.

Before: wowscrnshot_011519_193546

After: wowscrnshot_011519_193631

p3lim commented 5 years ago

Not having played warrior myself, are all the destinations available from the start?

Also, the flight master icons would be my choice as well.

On 16 January 2019 01:38:08 CET, Rob notifications@github.com wrote:

This is for the flight master (Stormflight Master) NPC in Skyhold (class hall for Warriors in Legion).

There's probably a better icon to use than the flight master boot but I don't know what to use for this at the moment.

"Broken Shore" is one of the destinations but it is already translated so I left it where it is.

Before: wowscrnshot_011519_193546

After: wowscrnshot_011519_193631

You can view, comment on, or merge this pull request online at:

https://github.com/p3lim-wow/InteractiveWormholes/pull/11

-- Commit Summary --

  • Create Skyhold.lua
  • Load new Skyhold module
  • Empty translations for Legion zones
  • Empty translations for Legion zones
  • Empty translations for Legion zones
  • Empty translations for Legion zones
  • Empty translations for Legion zones
  • Empty translations for Legion zones
  • Empty translations for Legion zones
  • Empty translations for Legion zones
  • Empty translations for Legion zones
  • Empty translations for Legion zones

-- File Changes --

M locale/deDE.lua (8) M locale/esES.lua (8) M locale/esMX.lua (8) M locale/frFR.lua (8) M locale/itIT.lua (8) M locale/koKR.lua (8) M locale/ptBR.lua (8) M locale/ruRU.lua (8) M locale/zhCN.lua (8) M locale/zhTW.lua (8) A modules/Skyhold.lua (35) M modules/modules.xml (1)

-- Patch Links --

https://github.com/p3lim-wow/InteractiveWormholes/pull/11.patch https://github.com/p3lim-wow/InteractiveWormholes/pull/11.diff

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/p3lim-wow/InteractiveWormholes/pull/11

tiker commented 5 years ago

The destinations are not available from the start. I think Dalaran is the only one available from the start.

For the rest of the destinations, you need to have travelled to them on your own first. Then they become available from the NPC.

In my case, Dalaran and the Broken Shore were the only two I had at first but I had been to the Broken Shore before I even did the quest to unlock access to the Warrior class hall.

tiker commented 5 years ago

Now that I think about it, my Warrior hasn't been to Argus yet. I doubt that there will be an option for Argus since you can't fly there with a normal flight (bird) but I'll check that tonight to confirm.

p3lim commented 5 years ago

Any update on Argus?

tiker commented 5 years ago

My Warrior hasn't fully unlocked all of Argus but so far, nothing. I don't think there will be a port here.

p3lim commented 5 years ago

Alright.

p3lim commented 5 years ago

See https://github.com/p3lim-wow/InteractiveWormholes/commit/d9d1e25cff1818bce24df4445590cb60e1df1e0b.

tiker commented 5 years ago

The changes for Highmountain does not work.

[addon:GetMapName(750)] = {zone = 750, x = 0.3853, y = 0.4554}, -- Highmountain

The text from the NPC says Highmountain but you end up in Thunder Totem (sub zone in Highmountain which is zone 750).

p3lim commented 5 years ago

I'd rather add the relative coordinate in Highmountain than adjusting the localization. https://github.com/p3lim-wow/InteractiveWormholes/commit/c73d160d4fe85f81855014c2dc59d032aefa027d

tiker commented 5 years ago

Couldn't you just do this:

[addon:GetMapName(650)] = {zone = 750, x = 0.3853, y = 0.4554}, -- Highmountain

Get the name of Highmountain for the text match and still put the pin in Thunder Totem?

p3lim commented 5 years ago

Derp, you're right.