p3lim-wow / InteractiveWormholes

Shows clickable locations on the World Map when using engineering wormholes
Other
4 stars 5 forks source link

Dark Iron dwarf Mole Machine not working #13

Closed Bexan closed 5 years ago

Bexan commented 5 years ago

Using Version 80100.10-Release

Clicking a destination for the Mole Machine only closes the map and takes me nowhere. This is the Error message wow provides

Message: ...s\InteractiveWormholes\modules\UnderbellyPortals.lua:16: attempt to compare number with nil Time: Sun Jan 20 14:54:23 2019 Count: 12 Stack: ...s\InteractiveWormholes\modules\UnderbellyPortals.lua:16: attempt to compare number with nil

...s\InteractiveWormholes\modules\UnderbellyPortals.lua:16: in function `callback' Interface\AddOns\InteractiveWormholes\addon.lua:130: in function <Interface\AddOns\InteractiveWormholes\addon.lua:116>

Locals:

p3lim commented 5 years ago

Please try that change before I push out a new release, just in case there are any other issues I've missed (I don't have a DIDwarf so I can't test myself).

Bexan commented 5 years ago

Tried it, still same result, just looks like this when I try using it, no error message pops up at all now

https://gyazo.com/4841d2ed1111d63249b35d578c4a19e0

Should probably clarify that it is working for me with all the other modes of travel without error, only the mole machine isn't working, and it gives me the same issue with InteractiveWormholes being the only addon enabled

p3lim commented 5 years ago

I see the issue now, I'll get a fix out shortly.

p3lim commented 5 years ago

Seems there is still some weird issue with this.

p3lim commented 5 years ago

So, the issue I'm seeing (this is very technical, but I'm dumping this info regardless) is when I "hide" the default gossip window (by unregistering the event that would normally show it) I lose track of the NPC it exists for, so when the second gossip window shows, it has no NPC correlated with it, thus none of the zones gets clicked (and this is why you'd see the gossip window when you click the zone).

p3lim commented 5 years ago

Found a (slightly hacky) solution: https://github.com/p3lim-wow/InteractiveWormholes/commit/d50f65e931c85b32bb4a94ac36a52fab8b77f42d https://github.com/p3lim-wow/InteractiveWormholes/commit/f3510e90ab837ce1f139f9bb8f7b8b08fe8a808b

The reason we had an invalid NPC was because we closed the gossip prematurely, the delay fixes that.

Bexan commented 5 years ago

Gonna give it a go when I'm back at my pc, thanks for the help!

p3lim commented 5 years ago

@Bexan Did you end up testing it?

Bexan commented 5 years ago

Sorry, dissapeared from wow for a bit. Back now and tried the changes to addon.lua and the molemachine module but still getting the same issue, it closes out without sending me anywhere. The only difference I found now is that if I interact with the mole machine quickly again after attempting to go somewhere, it'll just open the normal in game map, without any clickable wormhole icons : / Closing the map and interacting with the wormhole again gets me the map with the interactable icons, but still no functionality.