search

p3lim-wow / InteractiveWormholes

Shows clickable locations on the World Map when using engineering wormholes
Other
5 stars 6 forks source link

Dark Iron Dwarf Mole Machine does not function #16

Closed jrowles closed 4 years ago

jrowles commented 5 years ago

Version: 80100.12-Release

When I attempt to use the Mole Machine, it just closes the map and nothing happens. This is a duplicate of #13 but that ticket is closed.

p3lim commented 4 years ago

I'm unable to reproduce this, not on the live servers nor on the Shadowlands beta with the updates for that.

jrowles commented 4 years ago

This is still an issue for me on live. I will try it later with all other addons disabled.

jrowles commented 4 years ago

I'm still trying to narrow down the conflict. I created a brand new level 20 DID and it works fine with the same addons enabled as my 120, but my 120 still has the issue.

p3lim commented 4 years ago

How many of the locations have you discovered on your 120 character?

jrowles commented 4 years ago

How many of the locations have you discovered on your 120 character?

All of them.

p3lim commented 4 years ago

Alright, I can't guarantee any timeline for a fix, as I don't play alliance at all, but I'll try to look into it since it seems to be related to the amount of known locations.

p3lim commented 4 years ago

Do you happen to play with a non-english client?

jrowles commented 4 years ago

Do you happen to play with a non-english client?

No. My 120 is a race change, but I doubt that's related.

p3lim commented 4 years ago

I'll unlock and level a Dark Iron Dwarf once prepatch hits so I can test this out myself, I'd do it on the PTR/beta, but it'd be nice to have all those locations unlocked on a character that doesn't get deleted automatically.

Until then, if you have any experience with addon development (or any others reading this), feel free to try out stuff to help me figure out what's wrong, as I can't see anything from my limited interactions with the racial.

p3lim commented 4 years ago

Had some spare time this weekend, tested out all the mole machine locations properly, had to make a few changes for it to work.

p3lim commented 4 years ago

Alpha build artifact is now available, they can be found by looking at the "Package and create artifact" CI job from the commit: image

then downloading the artifact from the top-right: image

(Or if you just want to test these specific changes, here is a direct link to the latest build as of writing this).

p3lim commented 4 years ago

With that you should be able to help test the changes, without having to download anything extra. Let me know if something doesn't work.

jrowles commented 4 years ago

@p3lim Thank you, I will give it a try and let you know!

jrowles commented 4 years ago

Unfortunately, this still doesn't work. It just closes the map instead of teleporting. One of them randomly worked, though. Mount Hyjal "worked" by taking me to Stormwind instead. This leads me to believe your continent indexes are wrong.

p3lim commented 4 years ago

The continent indices are calculated by their order, and flagged as available if the hidden quest is completed. Can you disable the addon, talk to the mole machine and take screenshots of the list of continents and all the locations within?

jrowles commented 4 years ago

It looks like it matches. image

p3lim commented 4 years ago

Also, to verify, have you tested it with just InteractiveWormholes enabled?

jrowles commented 4 years ago

Also, to verify, have you tested it with just InteractiveWormholes enabled?

Yes, same issue.

jrowles commented 4 years ago

I clicked Nethergarde Keep, nothing happened. I opened the Mole Machine again, briefly saw the gossip menu, then clicked Nethergarde Keep a second time, and it took me to Honor Hold. I will take a video for you to watch next time the cooldown is up.

p3lim commented 4 years ago

Nethergarde Keep a second time, and it took me to Honor Hold

Those are not even on the same continent, that makes no sense 😕. By the indexes Nethergarde Keep is 1-3, while Honor Hold is 3-1, they should not possibly be clicked the other way around because only the continent is selected during the click, which triggers the gossip event and selects the actual location.

jrowles commented 4 years ago

https://www.youtube.com/watch?v=i-FLys2--_Q

p3lim commented 4 years ago

Ah, fullscreen map, never tested that.

p3lim commented 4 years ago

Just to confirm, if the map is not full screen, does it work properly for you? I will investigate what's making the full screen map break the logic, but atleast now I'm able to replicate what you're seeing.

jrowles commented 4 years ago

I will let you know shortly (30 minute cooldown) :)

p3lim commented 4 years ago

(30 minute cooldown)

Hence why I wanted to create a proper character on live servers, now I can copy it infinitely on the beta and don't have to wait for the cooldown to test it ;).

p3lim commented 4 years ago

So what InteractiveWormholes does when it displays the map is to disable the default UI from knowing that the gossip window was closed, keeping the NPC talking to you. This does not work while the map is full screen, I assume it triggers some "close-all-other-windows" thing, which I'll see if I can get around.

jrowles commented 4 years ago

Alternatively, can you open the map in the smaller mode automatically?

p3lim commented 4 years ago

I could, but I'd rather fix properly if possible.

p3lim commented 4 years ago

Try out this one whenever you find the time: https://github.com/p3lim-wow/InteractiveWormholes/suites/1291141546/artifacts/20132770

This should work with both full screen and normal world map.

jrowles commented 4 years ago

Success! Thank you for your time in fixing this issue.

p3lim commented 4 years ago

And thank you for taking the time to helping me test it.

Fixed with d2d0a2e and 4010b1a.