search

p3lim-wow / InteractiveWormholes

Shows clickable locations on the World Map when using engineering wormholes
Other
4 stars 5 forks source link

Add support for Dalaran Underbelly portals #7

Closed tiker closed 5 years ago

tiker commented 5 years ago

I thought it would be good to have this add on support the portals you can learn in Dalaran Underbelly (Legion) so I quickly tossed this together.

I've only tested it with one character so far which has all of the portals unlocked.

Feel free to add this addition to your addon, modify it to your needs, etc.

p3lim commented 5 years ago

https://www.wowhead.com/npc=97363/khuta

tiker commented 5 years ago

I'll make the suggested corrections. This was just a quick version to get something working.

p3lim commented 5 years ago

I don't expect you to do all of the localization yourself, just adding them commented out as I've done is enough, other contributors can help. :)

tiker commented 5 years ago

I'll translate what I can with Wowhead but I don't have any way of verifying the information is correct. I'd rather have a translation that's close to correct than nothing at all. Makes it a bit easier for someone to verify or correct if they have a bit of an idea what should be there.

Question is, do you want me to leave the unverified translations in place or comment them out until someone confirms them?

tiker commented 5 years ago

Also, just so you know, I'm working on these changes without access to Warcraft to verify them. I'll verify them tonight when I get home. Don't assume they're good until I verify them tonight.

p3lim commented 5 years ago

Leave them commented out tbh, I should probably have a system in place to trigger people to contribute when there's a mismatch of options and working strings, but that's for another time.

Just let me know when you feel you're finished with the PR and I'll do the last finishing touches myself if necessary.

tiker commented 5 years ago

Have a look at it now. I think I've resolved everything you mentioned.

p3lim commented 5 years ago

Thank you for your contribution.