p3yt0n13 / universal-pokemon-randomizer

Automatically exported from code.google.com/p/universal-pokemon-randomizer
0 stars 0 forks source link

ROM won't play in VBA after randomising trainers #1

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Open Fire Red (U) 1.0
2. Select Trainers Pokemon - Random
3. Click Randomize and save
4. Open with VBA

What is the expected output? What do you see instead?
VBA reports an error "Unsupported rom size 94"

Please provide any additional information below.

Trainers in the Gen3 games have 2 formats that they can take.  I inspected the 
rom, and it looks like you are only handling the first one.

Most trainers will be:
[AA LL PP II] * number of pokemon
AA is the AI level
LL is the pokemon's level
PP is the pokemon
II is the pokemon's held item
(all values are 2 bytes)

Some trainers (e.g. gym leaders) also specify the moves of the pokemon:
[AA LL PP II MM MM MM MM]
AA is the AI level
LL is the pokemon's level
PP is the pokemon
II is the pokemon's held item
MM is the index of a move (or 0 for no move in that slot)
(all values are 2 bytes)

You can see which format a trainer will have in the trainer data (where the 
name, class, sprite etc. is specified).  The first byte will be 0 (no moves or 
items), 1 (moves specified), 2 (held items specified) or 3 (moves and held 
items specified).

Original issue reported on code.google.com by pateandrew@gmail.com on 26 Dec 2012 at 4:41

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
It looks like VBA doesn't work unless I get the file extension right, so this 
was my fault.  Everything works properly if the rom is renamed.

Original comment by pateandrew@gmail.com on 26 Dec 2012 at 6:12

GoogleCodeExporter commented 8 years ago
Go ahead and delete this issue.

Original comment by pateandrew@gmail.com on 26 Dec 2012 at 6:12

GoogleCodeExporter commented 8 years ago
Closing as not an issue. Am going to improve the file saving feature to add 
appropriate extensions automatically as you'd expect though!

Original comment by dabomstew on 26 Dec 2012 at 6:15