p4535992 / conditional-visibility

a FoundryVTT module to hide tokens from some players, but not from others
MIT License
5 stars 8 forks source link

Still not respecting passive perception on observer tokens[BUG] #14

Closed ctbritt closed 2 years ago

ctbritt commented 2 years ago

Module Version: v0.4.28

Describe the bug the show/hide function seems just broken. If I have a token (the Hider) and I roll a stealth roll (16), then my Observing tokens (Observers) should or should not be able to see Hider based on their passive perception score, which is fixed in DnD5e. Let's say I have three Observers (1,2,3) Observer1 has 20 passive perception, Observer2 has 16, and Observer3 has 12. Obsv1 and 2 should be able to see Hider's token, while Obsv3 should not.

But at present, on the DM's screen, no matter what Hider rolls, no one can see the token, even if it's a low roll. On the player's screen, everyone can see Hider regardless of his roll.

To make matters worse, if Obsv 3 makes a perception roll, the Hidden (CV) condition via Dfred's gets applied to her token!

The topic of invisibility is also rather garbled. If I apply the Invisibility (CV) condition to a Hider2, and then adjust the senses on Obsv1,2,3 to See Invisible > 120, then Hider2 is ... still invisible on both the player's and DM's screens.

True Sight is equally unable to see the invisible Hider token.

Here are some settings.

These are the settings from Hider1, who just rolled a 16 stealth check:

Screen Shot 2022-03-16 at 10 34 07 PM

Here is Hider2, who is invisible:

Screen Shot 2022-03-16 at 10 39 38 PM

Here is my Observer, who has a passive perception of 24, so she should be able to see Hider1 (stealth roll of 16). She also has a lantern of revealing, which shows invisible beings within 30 feet of her:

Screen Shot 2022-03-16 at 10 39 53 PM

The old version of the module worked reasonably well. It didn't really allow for things like True Sight or Devil's sight, or a range of vision such as you'd see in a lantern of revealing (30-foot radius to see invisible stuff) but it at least handled auto stealth rolls and whether a token was visible based on the Observer's passive perception.

I hate to complain since this is a free module and the developer is doing great work to keep it going, but at the moment, the functionality seems just broken, the documentation is a bit confusing, and it just doesn't work as expected.

Browser: Chrome Version 99.0.4844.51 (Official Build) (arm64)

Foundry Version: v9.255 Game System: DnD5e 1.5.7

p4535992 commented 2 years ago

I tried to fix the problem in version 0.4.29, if you still see some problems enable the setitngs debug module and pass me the logs. I tried to update the documentation https://github.com/p4535992/conditional-visibility/blob/master/wiki/tutorial.md, try to tell me if it comes back to you (for the documentation you could also help in enriching it if it doesn't seem clear enough)

Avitale34 commented 2 years ago

image Having a similar issue a creature with passive perception of 11 is seeing something hidden with 21 stealth.

p4535992 commented 2 years ago

@Avitale34 Enable the debug module setting and show me what logs are you seeing, it's seem to work fine on my test. With the latest version 0.4.32 i mean.

p4535992 commented 2 years ago

Should be solved with the new 0.5.x series.