p4535992 / conditional-visibility

a FoundryVTT module to hide tokens from some players, but not from others
MIT License
5 stars 8 forks source link

[BUG] Invisibility not respected while auto stealth is. #18

Closed ctbritt closed 2 years ago

ctbritt commented 2 years ago

Module Version: v0.4.35

Before open any issue

1) Enable the module setting "Enable debugging" 2) Click F12 go to the console tab 3) make the test you want and replicate the error 4) Go to the tab console open on point 2) and just right click and click 'Save as' and 'Save'. 5) attach the text file on the github issue

Describe the bug Auto stealth is now working correctly, but invisibility still seems to need some work. In the annotated screenshot below, Bandit (Token A) has a passive perception of 14, Zanna (B) has a passive perception of 11, and Scout (C) has a stealth roll of 14. B is also invisible.

A can see C because its passive perception equals or exceeds C's stealth roll. B cannot see C because its passive perception is lower than C's stealth roll. All good. However, both A and C can see B, even though it's invisible. B's token should not appear to either of A or C.

I've attached the debug report.

I then looked at the default Dfred's condition for Invisible. it's set to ATCV.invisible > custom > 0, when it should be 1, I think. I've edited the effect to be 1, and B now properly disappears, so that's a fix in the defaults that might be made.

However, applying See Invisible > custom > 2 or greater does not make the invisible B visible to the other tokens.

Screenshots If applicable, add screenshots to help explain your problem.

Screen Shot 2022-03-18 at 4 41 16 PM

Browser: Chrome 99.0.4844.74 Foundry Version: v9.255 Game System: Dnd 1.5.7

A-B-C.log

p4535992 commented 2 years ago

try out 0.4.38

img1 img2 img3 img4

if something still don't work, i need you to export these actor, maybe threre is some flag or module incompatbiliy i'm missing. Remember i made this table https://github.com/p4535992/conditional-visibility/blob/master/wiki/table_dnd5e.md for check what 'sense' can see that 'condition' tell me if i made something wrong. By default the hidden state value override the stealth passive from the actor 5e , so for the bandit with 19 of stealth passive the module will use instead the 14 hidden value for the check with the passive perception, tell me if you need some setting for manage this behaviour.

ctbritt commented 2 years ago

I think you might be complicating things a bit with the passive stealth, but that might just be a play style. When I play, I only allow stealth when the players say they're trying to be sneaky. Then we roll stealth and if it's lower than, say, a guard's passive perception, the guard spots them. The guard is not actively looking for them. The players never get the benefit of stealth as a passive feature. So I think you could probably drop that entire aspect the module (passive stealth) if that's causing problems?

ctbritt commented 2 years ago

So far, everything is looking good, once I updated the DFred’s effects.

p4535992 commented 2 years ago

yes i think i rewrite some stuff, for make the checker more simple