p4535992 / conditional-visibility

a FoundryVTT module to hide tokens from some players, but not from others
MIT License
5 stars 8 forks source link

[BUG] module is conflicting with MIDI #45

Closed rinnocenti closed 1 year ago

rinnocenti commented 2 years ago

Module Version: v0.6.11

Describe the bug bonus from any attribute on damage is reset

To Reproduce Steps to reproduce the behavior:

1) have the MIDI and CV modules active. 2) The MIDI module with full Automation. fvtt-midi-qol-settings.zip

3) attacks have their damage bonus by attributes reset to zero.

image

Expected behavior as the module should operate only the field of vision it shouldn't interfere with the generation of attack cards in the chat, but it's happening.

rinnocenti commented 2 years ago

I changed the MIDI play order (as a priority) and the CV (without priority) in libwrapper and it got it right again.

but I still don't know if it causes other problems.

p4535992 commented 2 years ago

there seems to be a synchronization problem between the updates of the actor between the two modules, I didn't understand anything, but Tim seems to have found the solution on his side with Midi it should be solved with the next Midi release