Closed r-valyar closed 1 year ago
I would like to follow up on that as well please, module has stopped working FVTT v11 b300 dnd v 2.2.1
please!
To add to this, the module seems to still work in v11 if you alter the module.json to claim it's compatible, but it creates dozens of console warnings as messages are sent in chat. When I do an attack with Midi and some other modules a single attack/damage roll winds up creating about 9-12 console warnings. I'm not sure if there's an issue with yellow warnings, and there's no red errors, but it does worry me that if it's creating so many flags that it might cause some slowdown or something, but that's just a fear.
Let me add my voice into the chorus of wishing for a V11 update. :)
Nice module, would be nice to see it running in v11. 🙂
+1
+1
here +1 o/
I made a fork and did a tiny bit to get it working. It really only needed two things: an update to the manifest to say it supports v11, and updating a deprecated usages of grabbing the token images from the actor (to clear up the console warnings). You can see my single commit to my fork where I tweaked things (much of which was playing around figuring out how to get the code into a release state)
You can install it via: https://github.com/BradleyStaples/foundryvtt-chat-portrait/releases/latest/download/module.json if you'd like until p4535992 might have time to do a fix. I probably won't do much more than this, mainly wanted to see if it was hard to fix for my own Foundry instance. If you do install, you probably (?) want to remove the current/old version and then install this one afterwards. That'll also mean each user for each world will need to redo their settings for this module.
That worked great. Thanks Bradley!
I made a fork and did a tiny bit to get it working. It really only needed two things: an update to the manifest to say it supports v11, and updating a deprecated usages of grabbing the token images from the actor (to clear up the console warnings). You can see my single commit to my fork where I tweaked things (much of which was playing around figuring out how to get the code into a release state)
You can install it via: https://github.com/BradleyStaples/foundryvtt-chat-portrait/releases/latest/download/module.json if you'd like until p4535992 might have time to do a fix. I probably won't do much more than this, mainly wanted to see if it was hard to fix for my own Foundry instance. If you do install, you probably (?) want to remove the current/old version and then install this one afterwards. That'll also mean each user for each world will need to redo their settings for this module.
You should probably make a pull request so p4535992 can incorporate your fix. If everything works, should make it easier for him to update it =)
Is there plan to update the module to support Foundry v11?