p4535992 / foundryvtt-chat-portrait

Other
2 stars 6 forks source link

[BUG] Two portraits (new and old) instead of just one (new) #45

Open Altro opened 6 months ago

Altro commented 6 months ago

Module Version: v0.9.7

Bug description Once module is enabled, all new chat messages contain two portraits: one from the enabled module (all settings apply to it) and one default (the one that Foundry used before the module was enabled). So the module does not replace the original chat portrait, but adds a new one instead.

Steps to reproduce the behavior

  1. Enable module.
  2. Make any roll.

Expected behavior Chat message contains only one portrait.

Screenshots image

Browser: Chrome

Foundry Version: Version 11 Stable (315)

Game System: D&D 5e

Altro commented 6 months ago

I've also tried replicating the bug on a new game without any other modules enabled, and the bug replicates successfully. Hence, the issue is not a module conflict.

p4535992 commented 6 months ago

Not sure about the other settings, but it should be enough to enable this settings "Disable chat portrait". If the problem persist i need to see the settings .... you can use this module to pass to me the setitngs: https://foundryvtt.com/packages/forien-copy-environment/

Altro commented 6 months ago

The "Disable chat portrait" disables the module-generated portraits and keeps the default ones. Since I downloaded the moded specifically for the module-generated portraits, I'd need the opposite.

Attaching the JSON extracted via that the module you gave.

Also, thank you so much for getting back so quickly! <3

foundry-settings-export-2024-04-01-18-06-37-family-matters.json

p4535992 commented 6 months ago

a ok so you want to disable the system one in favor of the module one ?

Altro commented 6 months ago

Yes, indeed. The new module portraits are the reason I downloaded the module. And on all of the images in module description there are only module portraits, without system portraits at all. This is the expected behaviour I'm trying to achieve. e.g. : https://raw.githubusercontent.com/p4535992/foundryvtt-chat-portrait/master/wiki/images/hooks_feature.png

jayseaseven commented 5 months ago

I'm seeing the same thing. In this picture I would just ideally want the square icon and not the circle one from default. image

p4535992 commented 3 months ago

After looking at Dnd5e and Pf2e , I decided not to support the "removal" of the default avatar , as too many conflicts with other modules would arise.

The module still remains supported, for all those systems that still do not support portraits in default chats.

It is possible to remove with the appropriate setting the portrait generated dq this module in favor of the system portrait for those using the other features provided by the module.