search

p4535992 / foundryvtt-pin-cushion

Adds additional functionality around Map Pins
GNU General Public License v3.0
3 stars 6 forks source link

Feature request: General support for page and header links #64

Closed King-Wedgie closed 1 year ago

King-Wedgie commented 1 year ago

Core FoundryVTT v10 supports dropping header links inside journals and other text areas, but weirdly not for scene notes; Journal Anchor Links actually adds in this function. Would love to have the co-ability(?) for Pin Cushion's text preview to auto-scroll to linked headers.

King-Wedgie commented 1 year ago

After further testing, I found that header AND page links are broken in general with the text preview. I've updated the issue name accordingly. image

p4535992 commented 1 year ago

Should be fixed on 1.8.33. Let me know it.

King-Wedgie commented 1 year ago

FoundryVTT v10.291 Pathfinder 2E v4.11.2 Pin Cushion v1.8.33

Should be fixed on 1.8.33. Let me know it.

Unfortunately not, as seen below: image The map note was made from the "B1. Beach" subheader, but the preview text starts at the top of the entire page section ("CHAPTER 1: FISHING FOR ADVENTURE").  To clarify, the expected result is for the note preview to be just the Page it was pulled from, but auto-scrolled to the subheader that was used to create the map note. An option to limit a note to just it's header and subheaders would be useful as well, though.

Additionally, Page and Header links in the preview are still broken (green), and notes dropped from Page headers now add every subheader underneath it to the Text Label (red): image

Let me know if you want these submitted as separate issues.

p4535992 commented 1 year ago

can you export the journal and pass to me ?

King-Wedgie commented 1 year ago

fvtt-JournalEntry-journal.json.txt Here's the generic journal from the last image. I can't upload the Troubles in Otari journal, as it's an import of a paid PDF.

Also, after further testing, the broken links only happen when pages and header links are dropped inside their own journal; pages and headers from other journals work perfectly.