search

p4535992 / foundryvtt-rarity-colors

MIT License
0 stars 1 forks source link

[BUG] Since the last update, using the "rarity color only as background not text" setting makes text black and nearly unreadable #6

Closed SirAron111 closed 10 months ago

SirAron111 commented 11 months ago

Module Version: v0.0.0

Before open any issue

localhost-1701980530973.log

Describe the bug The Colors of the text from items is nearly unreadable if it turns Black due to setting the background as the colored part..

To Reproduce Steps to reproduce the behavior:

  1. Set the setting rarity color only as background not text to true
  2. watch the text turn black and become nearly unreadable on the darker colors.

Expected behavior i like the background colored more than the text, but the text should still be readable.

Screenshots Unbenannt

Foundry Version: V11

Game System: DnD5E

p4535992 commented 10 months ago

Try to fix this on 0.3.8

SirAron111 commented 10 months ago

Mostly fixed, but not for Legendary Items and Artifacts. Unbenannt

p4535992 commented 10 months ago

After many tests, i can confirm is not a bug... according to the HSP Color Model — Alternative to HSV (HSB) and HSL and testing with three different libraries ..

Also i think you are using the tidy sheet kgar ? If is this the case the color picker is separated... you must use the color picker on that module or ask for a better integration with this module.

On the new version 0.3.10 i add some module settings for customize the color threshold and the alpha value.

SirAron111 commented 10 months ago

The last update fixed it. Thanks for the hard work and great modules.