p4535992 / foundryvtt-variant-encumbrance-dnd5e

A FoundryVTT module, providing a visual modification to player character sheets to better display the effects of the Encumbrance variant ruleset in the PHB.
MIT License
3 stars 4 forks source link

ItemCollection/Item Container feature not working with Foundry v11 #22

Closed Amd321 closed 1 year ago

Amd321 commented 1 year ago

Module Version: v0.13.1

Describe the bug The option "Use equipped/unequipped feature of the ItemCollection/ItemContainer modules for the backpack" which gives compatibility with the Itemcollection/Item Container module by Tim Posney, is not functioning. When Variant Encumbrance + Weight is enabled on a sheet, unequipping a backpack made with Tim Posney's Item Container module (set to Weightless Unequipped), does not lessen the inventory weight, and the encumbrance Active Effect is not removed.

To Reproduce Steps to reproduce the behavior:

  1. Check the box for "Use equipped/unequipped feature of the ItemCollection/ItemContainer modules for the backpack" in "Variant Encumbrance+midi for dnd5e" settings.
  2. Enable "Variant Encumbrance + Weight" for character sheet
  3. Create a container that has a weight above 0 in the character sheet and set it to "Weightless Encumbrance"
  4. Add items with weight to character sheet until it just becomes encumbered, and the "Encumbered" Active Effect is added.
  5. Unequip backpack
  6. Weight is not lessened, nor is "Encumbered" Active Effect removed.

Expected behavior It is expected that when unequipping the backpack, the weight will be lessened, and the "Encumbered" active effect will be removed.

Browser: Firefox 115.0.3 (64-bit)

Foundry Version: Version 11 Stable, 11.306

Game System: dnd5e, 2.2.2

Additional context A container's "Weightless Encumbrance" feature of Tim Posney's module functions fine when the character sheet is set to "Disabled VE + WE", however the Variant Encumbrance function of adding and removing the "Encumbered" Active effect does not work still.

Also, this was tested with newest builds of "Variant Encumbrance+midi for dnd5e", "Itemcollection/Item Container", "Dynamic Active Effects using After Effects" and their dependencies, as the only modules active.

p4535992 commented 1 year ago

Should be fixed with 0.13.3 let me know it

Amd321 commented 1 year ago

It's even more screwed up now. Removing a bag will remove encumbrance, but you can't re-equip the bag, and now the VE + WE swap icon on the top of a character sheet is not functioning properly. The equip function of bags are super wonky now, and don't toggle correctly.

Dyrnwyrm commented 1 year ago

Same issue here, also for some reason the actives aura are visible when the module is active for some reason that i cant figure it out

p4535992 commented 1 year ago

Did you have any erorr on the web console ? Nevermind i see the error... try out 0.13.5

Amd321 commented 1 year ago

~Did you have any erorr on the web console ?~ Nevermind i see the error... try out 0.13.5

The toggle for "VE + WE" works again, and you can also toggle the equip of bags again, however, now bags with "Weightless Unequipped" don't reduce weight when unequipped anymore and the 'Encumbered' active effect isn't removed. (Basically, the whole point of the original bug report)

p4535992 commented 1 year ago

""Weightless Unequipped" don't reduce weight when unequipped" is working like expected, must be something on your side https://i.imgur.com/Fo6SB9U.gif.

img

can you click F12 and see if there is some error on the web console ?

Amd321 commented 1 year ago

Nothing on my side. No errors. I'm only using the required modules which are all up to date. Also, don't see you testing with the encumbered effect so that might be a thing. Should also be removing encumbered or adding encumbered active effect.

Amd321 commented 1 year ago

1 2 As you can see it does not function with "Variant Encumbrance + Weight" is enabled on a sheet. However it does function when they are disabled, which defeats the whole purpose as it doesn't work with DAE to add or remove encumbrance.

p4535992 commented 1 year ago

Sorry completely forgot about this, cannot replicate on my actors can you pass to me the actor json file ? (rename with suffix .txt for upload on github) @Amd321