search

p4535992 / foundryvtt-variant-encumbrance-dnd5e

A FoundryVTT module, providing a visual modification to player character sheets to better display the effects of the Encumbrance variant ruleset in the PHB.
MIT License
3 stars 4 forks source link

[BUG][Compatibility Module Inventory+] "Enable/Disable feature for applying Active effects for specific actors" Deselecting this option breaks the module. Bulk is no longer tracked, and it breaks some of the options for Inventory+. #6

Closed Orionox closed 7 months ago

Orionox commented 1 year ago

Module Version: v0.11.7

Before open any issue Inventory+ "Ignore Weight Test." Screenshot 2022-11-06 082405 Inventory+ "Ignore Bulk Test." Screenshot 2022-11-06 082519 Bulk tracking Test Screenshot 2022-11-06 082804

Describe the bug While the option "Enable/Disable feature for applying Active effects for specific actors" is deselected bulk is no longer tracked properly. Additionally, both the ignore weight and ignore bulk options from Inventory+ stop working. Reselecting that option restores bulk tracking and inventory+ functionality.

To Reproduce

  1. Open Configure Game setting
  2. Go to the variant encumbrance options.
  3. Deselect "Enable/Disable feature for applying Active effects for specific actors" Screenshot 2022-11-06 083154
  4. Open character sheet and bulk will no longer be properly tracked and the inventory+ options will have stopped working.
  5. Re-Enabling the "Enable/Disable feature for applying Active effects for specific actors" option restores functionality.

Expected behavior The "Enable/Disable feature for applying Active effects for specific actors" option is for people who want to or need to change how encumbrance is tracked on a player-by-player basis. Since I do not need that functionality, and since the "Enable/Disable feature for applying Active effects for specific actors" affects performance I want to disable it. With it disabled I'd expect the variant encumbrance to still work properly.

Foundry Version: V10.288 Game System: 5e V2.0.3 Additional context If you need additional screenshots of the debug WITH the "Enable/Disable feature for applying Active effects for specific actors" option activated I can provide that as well. Lastly, do you have a tip jar or something? you do such a phenomenal job with support I'd like to toss you something!

p4535992 commented 1 year ago

Can you pass to me the actor ? (rename with .txt the .json file for github limitation>)

Orionox commented 1 year ago

It happens with all my actors.

On Mon, Nov 7, 2022, 06:37 4535992 @.***> wrote:

Can you pass to me the actor ? (rename with .txt the .json file for github limitation>)

— Reply to this email directly, view it on GitHub https://github.com/p4535992/foundryvtt-variant-encumbrance-dnd5e/issues/6#issuecomment-1305628819, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEZBNPUKJLPNG26QXAJXGHLWHEAXZANCNFSM6AAAAAARYPKTF4 . You are receiving this because you authored the thread.Message ID: @.*** com>

Orionox commented 1 year ago

fvtt-Actor-luke-wydusathat.txt

p4535992 commented 1 year ago

ty orionox i have already see the problem i will try to fix this week end