search

p455w0rd / p455w0rds-Library

Stuff commonly used by my mods
MIT License
6 stars 7 forks source link

World exploration causing massive frame lag #33

Closed RedBlockCreator closed 5 years ago

RedBlockCreator commented 5 years ago

Using the mod Lag Goggles and loading chunks(be it newly generated or previously generated) I discovered this library was causing a lot of fame skips. It was causing about 5,000,000ns/f of frame lag to be precise. To confirm the data i was getting i removed this mod and the problem ceased to exist.

p455w0rd commented 5 years ago

Yeah, I was informed of this and fixed it in dev. I'm hoping for pwlib and /dank/null updates tomorrow

RedBlockCreator commented 5 years ago

Great to hear. Mind if I ask what was causing it(just out or curiosity)?

p455w0rd commented 5 years ago

this implementation i was trying to do for caching raw blocks (actually i was just caching their positions) and relying on an interface implementation of my colored light shader since there are no capabilities for blocks..it was a just a bad idea..I've removed that system now in favor of only supporting tiles

ghost commented 5 years ago

I came here to report this same issue; glad to hear it's already been fixed!

Any ETA on when the fixed version will be released?

pyure commented 5 years ago

Our team is having the same concern. Does anyone know what p455w0rd's release cycle is like? I want to monitor regularly for fix.

asiekierka commented 5 years ago

:man_shrugging:

Sending a fix in about 10 minutes. And it even preserves block support!

asiekierka commented 5 years ago

https://github.com/p455w0rd/p455w0rds-Library/pull/43