search

p4lang / behavioral-model

The reference P4 software switch
Apache License 2.0
532 stars 327 forks source link

Implement notification support in `SimpleSwitch` #1167

Closed pudelkoM closed 1 year ago

pudelkoM commented 1 year ago

This PR implements support for notifications (idle timeouts, digests) in SimpleSwitch when build with PI.

The code of NotificationsCapture is taken verbatim from SimpleSwitchGrpc.

Context: Stratum is consuming the SimpleSwitch[Runner] downstream without gRPC support, as we're implementing that ourselves on top. We'd still like to use digests and idle timeouts, which can be delivered through the PI layer.

antoninbas commented 1 year ago

@pudelkoM please mark this as "Ready for review" when you believe it is ready to be merged

antoninbas commented 1 year ago

@pudelkoM sorry for the delay, I must have missed the notification when you marked this PR as "Ready for review". I am merging it now.