search

p4lang / behavioral-model

The reference P4 software switch
Apache License 2.0
538 stars 327 forks source link

Added initial PNA support into BMv2. Removed built modules (nanomsg and thrift). #1246

Closed rupesh-chiluka-marvell closed 3 months ago

rupesh-chiluka-marvell commented 5 months ago

Based on the discussions in the issue https://github.com/p4lang/behavioral-model/issues/1245#issuecomment-2063913408, removed nanomsg and thrift directories.

KrisNey-MSFT commented 4 weeks ago

hi - does this implement the P4 runtime API by chance?

antoninbas commented 4 weeks ago

hi - does this implement the P4 runtime API by chance?

No, there was no P4Runtime server added to the target, but I hope someone can do it in the future. There is no reason to have 2 versions of the target like we do for simple_switch (one with P4Runtime and one without).

KrisNey-MSFT commented 4 weeks ago

Would this be a lot of work? 😊

From: Antonin Bas @.> Sent: Thursday, September 5, 2024 10:49 AM To: p4lang/behavioral-model @.> Cc: Kristina Moore @.>; Comment @.> Subject: Re: [p4lang/behavioral-model] Added initial PNA support into BMv2. Removed built modules (nanomsg and thrift). (PR #1246)

hi - does this implement the P4 runtime API by chance?

No, there was no P4Runtime server added to the target, but I hope someone can do it in the future. There is no reason to have 2 versions of the target like we do for simple_switch (one with P4Runtime and one without).

— Reply to this email directly, view it on GitHubhttps://github.com/p4lang/behavioral-model/pull/1246#issuecomment-2332314113, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFJSI6DV2EFUKNURG3KLIOTZVCKPBAVCNFSM6AAAAABGSPFD4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZSGMYTIMJRGM. You are receiving this because you commented.Message ID: @.**@.>>

antoninbas commented 4 weeks ago

Would this be a lot of work?

Hard to tell. I would say not really, but it there may be some plugging required to make sure that P4Runtime / PI calls get turned into the right extern method calls. It's a bit different from simple_switch which has no "externs" (only built-in objects). IIRC, we had a plan on how to do that for psa_switch a while back, and it's not that hard.

KrisNey-MSFT commented 4 weeks ago

Yes, we definitely need P4 runtime :)