search

p4lang / behavioral-model

The reference P4 software switch
Apache License 2.0
538 stars 328 forks source link

Added Basic externs for PNA: Meter, Counter, Hash, etc #1261

Closed rupesh-chiluka-marvell closed 2 months ago

rupesh-chiluka-marvell commented 2 months ago

Part of Issue: https://github.com/p4lang/behavioral-model/issues/1245

qobilidop commented 2 months ago

Is there a way we can test the code?

antoninbas commented 2 months ago

Is there a way we can test the code?

I think the priority should be to add some PNA-specific tests (see https://github.com/p4lang/behavioral-model/pull/1255#issuecomment-2161297606).

rupesh-chiluka-marvell commented 2 months ago

Is there a way we can test the code?

I think the priority should be to add some PNA-specific tests (see #1255 (comment)).

Yes. Ok.

antoninbas commented 2 months ago

@rupesh-chiluka-marvell please break up this PR. Everything related to the pna-demo-L2-one-table.json test should be in its own PR, which I'd like to review & merge first. Unless I am missing something, this basic end-to-end test of PNA has no dependencies on the externs you want to add as par of this PR.

rupesh-chiluka-marvell commented 2 months ago

@rupesh-chiluka-marvell please break up this PR. Everything related to the pna-demo-L2-one-table.json test should be in its own PR, which I'd like to review & merge first. Unless I am missing something, this basic end-to-end test of PNA has no dependencies on the externs you want to add as par of this PR.

Yes. Ok.

rupesh-chiluka-marvell commented 2 months ago

@rupesh-chiluka-marvell please break up this PR. Everything related to the pna-demo-L2-one-table.json test should be in its own PR, which I'd like to review & merge first. Unless I am missing something, this basic end-to-end test of PNA has no dependencies on the externs you want to add as par of this PR.

Hi @antoninbas, @qobilidop , I created a new PR for the basic test of PNA here: https://github.com/p4lang/behavioral-model/pull/1262. Please review it.