p4lang / p4-applications

P4 Applications WG repo
107 stars 46 forks source link

Correction to the fixed header length in INT.mdk #71

Closed Sanjhana-Jayagopal closed 4 years ago

Sanjhana-Jayagopal commented 4 years ago

Fixes #70 With the addition of Domain Specific ID (2 bytes) ad Domain Specific Instruction (2 bytes), the new fixed header size is 16 bytes. This PR updates the INT fixed header size in Section 5.7 of INT.mdk.

jklr commented 4 years ago

@Sanjhana-Jayagopal Thanks for the review! We've recently changed the meaning of shim header length. It used to include itself (4B) but not any more, canceling out the additional 4B added for Domain extension. Hence 12B is correct.

We much appreciate any review comments on the draft. We will cut v2.0 tomorrow, and the draft has many recent changes, likely to have some confusing or incorrect statements.